Skip to content

Conversation

haugjan
Copy link
Contributor

@haugjan haugjan commented Oct 15, 2025

A plugin to search in Atlassian Jira

Copy link
Contributor

@cibere cibere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The Website of your plugin's plugin.json file should lead to your plugin's website, not Jira's website. In your case, you probably want https://github.com/haugjan/Flow.JiraSearch.
  2. The Disabled key is not one that you should be providing in your plugin's plugin.json file.

@@ -0,0 +1,12 @@
{
"ID": "BD32A62C-6F98-4541-AE8E-17B46458595F",
"Name": "JiraSearch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name here does not match the name in your plugin's plugin.json file.

Suggested change
"Name": "JiraSearch",
"Name": "Jira Search",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the very quick review. I really appreciate it.

I have implemented all the changes in my repo and here. So: Back to you.

Copy link
Contributor

@cibere cibere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, however I didn't preform a manual integration test

@haugjan
Copy link
Contributor Author

haugjan commented Oct 21, 2025

Hi @cibere , I'm not sure how to proceed here. Am I correct in assuming that someone else needs to merge this? I can't do it myself. Right?

@cibere cibere merged commit 299768e into Flow-Launcher:main Oct 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants